Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix calls to as_rgba_linear #3200

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix calls to as_rgba_linear #3200

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Fix the conversions

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 27, 2021
@mockersf mockersf added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior and removed S-Needs-Triage This issue needs to be labelled labels Nov 27, 2021
@mockersf mockersf added this to the Bevy 0.6 milestone Nov 27, 2021
@mockersf mockersf mentioned this pull request Nov 27, 2021
Closed
@alice-i-cecile alice-i-cecile added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Nov 27, 2021
@mockersf
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Nov 28, 2021
@mockersf
fix calls to as_rgba_linear (#3200)
3de391b 
# Objective

- After #3192, some places where `as_rgba_linear` was called were doing too many conversions

## Solution

- Fix the conversions
@bors
Copy link
Contributor

bors bot commented Nov 28, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title fix calls to as_rgba_linear [Merged by Bors] - fix calls to as_rgba_linear Nov 28, 2021
@bors bors bot closed this Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @alice-i-cecile