Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add methods to get reads and writes of Access<T> #3166

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - add methods to get reads and writes of Access<T> #3166

wants to merge 2 commits into from

Conversation

jakobhellermann
Copy link
Contributor

This makes it possible to e.g. show resource and component access on hover in bevy_mod_debugdump:
grafik

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 21, 2021
@jakobhellermann jakobhellermann added A-ECS Entities, components, systems, and events C-Enhancement A new feature S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Nov 21, 2021
alice-i-cecile
alice-i-cecile approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-motivated; dead simple. Neat!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Nov 21, 2021
mockersf
mockersf approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as most of this struct is already doc commented, could you add some for those two methods?

@cart
Copy link
Member

cart commented Dec 11, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 11, 2021
@jakobhellermann
add methods to get reads and writes of Access<T> (#3166)
a5ea38f 
This makes it possible to e.g. show resource and component access on hover in [bevy_mod_debugdump](https://github.com/jakobhellermann/bevy_mod_debugdump/):
![grafik](https://user-images.githubusercontent.com/22177966/142773962-320f6e5b-608e-4abb-88b8-78da4fefc166.png)
@bors
Copy link
Contributor

bors bot commented Dec 11, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add methods to get reads and writes of Access<T> [Merged by Bors] - add methods to get reads and writes of Access<T> Dec 11, 2021
@bors bors bot closed this Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Enhancement A new feature S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakobhellermann @cart @alice-i-cecile @IceSentry @mockersf