Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - iter_mut() for Assets type #3118

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - iter_mut() for Assets type #3118

wants to merge 1 commit into from

Conversation

MiniaczQ
Copy link
Contributor

Objective

Fixes #3117

Solution

I took get_mut() and did it for all the elements 😏

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 13, 2021
@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A simple quality-of-life change that makes Bevy easier to use S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Nov 13, 2021
alice-i-cecile
alice-i-cecile approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin. Seems like a useful, if niche, addition and it would be very frustrating to need this if it doesn't exist.

@cart
Copy link
Member

cart commented Nov 13, 2021

Looks good to me!

@cart
Copy link
Member

cart commented Nov 13, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 13, 2021
@MiniaczQ
iter_mut() for Assets type (#3118)
8b30dc6 
# Objective

Fixes #3117 

## Solution

I took `get_mut()` and did it for all the elements 😏 


Co-authored-by: MiniaczQ <jakub.motyka.2000@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 13, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title iter_mut() for Assets type [Merged by Bors] - iter_mut() for Assets type Nov 13, 2021
@bors bors bot closed this Nov 13, 2021
@MiniaczQ MiniaczQ deleted the assets-iter-mut branch January 14, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add iter_mut() for Assets
3 participants
@MiniaczQ @cart @alice-i-cecile