Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove wasm audio feature flag for 2021 #3000

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Remove wasm audio feature flag for 2021 #3000

wants to merge 2 commits into from

Conversation

Ixentus
Copy link
Contributor

@Ixentus Ixentus commented Oct 21, 2021

Open questions:
Should we enable wasm audio by default or only when building for wasm using cfg?
Maybe there should be a global wasm feature for bevy?

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Oct 21, 2021
@alice-i-cecile alice-i-cecile added A-Audio Sounds playback and modification C-Code-Quality A section of code that is hard to understand or change S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Oct 21, 2021
@cart
Copy link
Member

cart commented Nov 6, 2021

We should only enable the wasm-bindgen feature when building for wasm. Here is an example of how we're doing this for renderer stuff in the new bevy renderer: https://github.com/bevyengine/bevy/blob/pipelined-rendering/pipelined/bevy_render2/Cargo.toml#L48

@cart
Copy link
Member

cart commented Nov 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 10, 2021
@Ixentus
Remove wasm audio feature flag for 2021 (#3000)
771c5f5 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 10, 2021
@Ixentus
Remove wasm audio feature flag for 2021 (#3000)
d98c2fe 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build failed:

@cart
Copy link
Member

cart commented Nov 11, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 11, 2021
@Ixentus
Remove wasm audio feature flag for 2021 (#3000)
36394ad 
- Requires #2997 
- Removes `wasm_audio` feature as discussed in #2397
- Closes only task in #2479 

Open questions:
Should we enable wasm audio by default or only when building for wasm using `cfg`?
Maybe there should be a global wasm feature for bevy?
@bors
Copy link
Contributor

bors bot commented Nov 11, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove wasm audio feature flag for 2021 [Merged by Bors] - Remove wasm audio feature flag for 2021 Nov 11, 2021
@bors bors bot closed this Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Audio Sounds playback and modification C-Code-Quality A section of code that is hard to understand or change
Projects
Audio
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ixentus @cart @mockersf @alice-i-cecile