Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Remove double Events::update in bevy-gilrs #2894

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Remove double Events::update in bevy-gilrs #2894

wants to merge 2 commits into from

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Sep 30, 2021

Objective

Solution

  • Do the change

r? @alice-i-cecile

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Sep 30, 2021
alice-i-cecile
alice-i-cecile approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM.

@alice-i-cecile alice-i-cecile added A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Needs-Review and removed S-Needs-Triage This issue needs to be labelled labels Sep 30, 2021
@mockersf mockersf added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review labels Oct 1, 2021
@mockersf
Copy link
Member

mockersf commented Oct 8, 2021

bors r+

bors bot pushed a commit that referenced this pull request Oct 8, 2021
@CAD97
Remove double Events::update in bevy-gilrs (#2894)
997eae6 
# Objective

- Remove duplicate `Events::update` call in `gilrs_event_system` (fixes #2893)
  - See #2893 for context
- While there, make the systems no longer exclusive, as that is not required of them

## Solution

- Do the change

r? @alice-i-cecile
@bors
Copy link
Contributor

bors bot commented Oct 8, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Remove double Events::update in bevy-gilrs [Merged by Bors] - Remove double Events::update in bevy-gilrs Oct 8, 2021
@bors bors bot closed this Oct 8, 2021
@CAD97 CAD97 deleted the gilrs-non-unique branch March 7, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

@NiklasEi NiklasEi NiklasEi approved these changes

Assignees
No one assigned
Labels
A-Input Player input via keyboard, mouse, gamepad, and more C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events<GamepadEventRaw> appears to be getting updated twice per world tick (gilrs)
4 participants
@CAD97 @mockersf @alice-i-cecile @NiklasEi