[Merged by Bors] - [assets] fix Assets being set as 'changed' each frame #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
commented
May 30, 2021
NathanSWard
added
A-Assets
NathanSWard
changed the title
mockersf
approved these changes
May 30, 2021
alice-i-cecile
approved these changes
May 30, 2021
NathanSWard
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
## Objective - Fixes: #2275 - `Assets` were being flagged as 'changed' each frame regardless of if the assets were actually being updated. ## Solution - Only have `Assets` change detection be triggered when the collection is actually modified. - This includes utilizing `ResMut` further down the stack instead of a `&mut Assets` directly.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
## Objective - Fixes: bevyengine#2275 - `Assets` were being flagged as 'changed' each frame regardless of if the assets were actually being updated. ## Solution - Only have `Assets` change detection be triggered when the collection is actually modified. - This includes utilizing `ResMut` further down the stack instead of a `&mut Assets` directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Res<Assets<T>>.is_changed()is true every frame, even when not changed #2275Assetswere being flagged as 'changed' each frame regardless of if the assets were actually being updated.Solution
Assetschange detection be triggered when the collection is actually modified.ResMutfurther down the stack instead of a&mut Assetsdirectly.