Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix Events::<drain/clear> bug #2206

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions crates/bevy_ecs/src/event.rs
Original file line number Diff line number Diff line change
Expand Up @@ -328,14 +328,25 @@ impl<T: Component> Events<T> {
events.update();
}

#[inline]
fn increment_start_event_count(&mut self) {
let count = self.event_count + 1;
self.a_start_event_count = count;
self.b_start_event_count = count;
NathanSWard marked this conversation as resolved.
Show resolved Hide resolved
}

/// Removes all events.
#[inline]
pub fn clear(&mut self) {
self.increment_start_event_count();
self.events_a.clear();
self.events_b.clear();
}

/// Creates a draining iterator that removes all events.
pub fn drain(&mut self) -> impl Iterator<Item = T> + '_ {
self.increment_start_event_count();

let map = |i: EventInstance<T>| i.event;
match self.state {
State::A => self
Expand Down Expand Up @@ -480,4 +491,40 @@ mod tests {
) -> Vec<TestEvent> {
reader.iter(events).cloned().collect::<Vec<TestEvent>>()
}

#[derive(PartialEq, Eq, Debug)]
struct E(usize);

fn events_clear_and_read_impl(clear_func: impl FnOnce(&mut Events<E>)) {
let mut events = Events::<E>::default();
let mut reader = events.get_reader();

assert!(reader.iter(&events).next().is_none());

events.send(E(0));
assert_eq!(*reader.iter(&events).next().unwrap(), E(0));
assert_eq!(reader.iter(&events).next(), None);

events.send(E(1));
clear_func(&mut events);
assert!(reader.iter(&events).next().is_none());

events.send(E(2));
events.update();
events.send(E(3));

assert!(reader.iter(&events).eq([E(2), E(3)].iter()));
}

#[test]
fn test_events_clear_and_read() {
events_clear_and_read_impl(|events| events.clear());
}

#[test]
fn test_events_drain_and_read() {
events_clear_and_read_impl(|events| {
assert!(events.drain().eq(vec![E(0), E(1)].into_iter()));
});
}
}