Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventConsumer #2145

Closed
wants to merge 20 commits into from
Closed

Add EventConsumer #2145

wants to merge 20 commits into from

Commits on May 11, 2021

  1. Code organization 

    Moves impl blocks directly after types, organizes like-types together, presents shared functionality first
    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    7c224f0 View commit details
    Browse the repository at this point in the history

  2. Added EventConsumer 

    Also added handy drain_with_id method
    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    8be5e90 View commit details
    Browse the repository at this point in the history

  3. Renamed State to BufferState for clarity 

    Event buffer's state should not clash with State concept
    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0140b63 View commit details
    Browse the repository at this point in the history

  4. Reverted to SystemParam only form of EventReader etc.

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    9ae131f View commit details
    Browse the repository at this point in the history

  5. Add into_inner for ResMut 

    Direct copy of into_inner for Mut
    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    620bbbc View commit details
    Browse the repository at this point in the history

  6. Fix lifetime errors in drain methods

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    42dad93 View commit details
    Browse the repository at this point in the history

  7. Added test for Event* as system parameters

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    766e25c View commit details
    Browse the repository at this point in the history

  8. Comments explaining tiny map functions

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0ca992e View commit details
    Browse the repository at this point in the history

  9. Fixed test!

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    bb18f07 View commit details
    Browse the repository at this point in the history

  10. Rename ei to instance for clarity

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    51b6195 View commit details
    Browse the repository at this point in the history

  11. Add event_consumer example

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    1da3c34 View commit details
    Browse the repository at this point in the history

  12. Move event.rs example to FixedTimeStep 

    Consistency with event_consumer and improves simplicity
    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    e1142ad View commit details
    Browse the repository at this point in the history

  13. Added note on need to call .drain to consume

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0d5185e View commit details
    Browse the repository at this point in the history

  14. Satisfy clippy

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    c7a90b1 View commit details
    Browse the repository at this point in the history

  15. Add events as a resource to avoid cleanup

    @alice-i-cecile
    alice-i-cecile committed May 11, 2021
    Configuration menu
    Copy the full SHA
    987a62f View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Add test that catches EventReader + drain failure observed in example 

    Fails on line 467, after we try again
    @alice-i-cecile
    alice-i-cecile committed May 12, 2021
    Configuration menu
    Copy the full SHA
    e0b64fd View commit details
    Browse the repository at this point in the history

  2. Reset events metadata when drained 

    Required to ensure Event readers continue functioning correctly
    @alice-i-cecile
    alice-i-cecile committed May 12, 2021
    Configuration menu
    Copy the full SHA
    591bfdd View commit details
    Browse the repository at this point in the history

  3. Removed redundant .to_string 

    Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
    @alice-i-cecile @NathanSWard
    alice-i-cecile and NathanSWard committed May 12, 2021
    Configuration menu
    Copy the full SHA
    defe65b View commit details
    Browse the repository at this point in the history

  4. Satisfy the cargo fmt gods

    @alice-i-cecile
    alice-i-cecile committed May 12, 2021
    Configuration menu
    Copy the full SHA
    3d0809f View commit details
    Browse the repository at this point in the history

  5. Fix typo 

    Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
    @alice-i-cecile @NathanSWard
    alice-i-cecile and NathanSWard committed May 12, 2021
    Configuration menu
    Copy the full SHA
    06d26e5 View commit details
    Browse the repository at this point in the history