Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Make Command's public? #2034

Closed
wants to merge 2 commits into from

Commits on Apr 27, 2021

  1. Make Command's public?

    I'm using Bevy ECS in a project of mine and I'd like to do world changes asynchronously. 
    
    The current public API for creating entities, `Commands` , has a lifetime that restricts it from being sent across threads. `CommandQueue` on the other hand is a Vec of commands that can be later ran on a World. 
    
    So far this is all public, but the commands themselves are private API. I know the intented use is with `Commands`, but that's not possible for my use case as I mentioned, and so I simply copied over the code for the commands I need and it works. Obviously, this isn't a nice solution, so I'd like to ask if it's not out of scope to make the commands public?
    deprilula28 committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    909b95b View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Update commands.rs

    deprilula28 committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    83c0d9a View commit details
    Browse the repository at this point in the history