Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Angle bracket annotated types to support generics #1919

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Angle bracket annotated types to support generics #1919

wants to merge 3 commits into from

Conversation

YohDeadfall
Copy link
Member

Fixes #1873. Types should be enclosed in angular brackets to avoid ambiquity and to correctly resolve associated functions.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Apr 13, 2021
YohDeadfall and others added 2 commits April 14, 2021 11:29
@YohDeadfall @TehPers
Fully qualified type name
0ddb17b 
Co-authored-by: TehPers <tehperz@gmail.com>
@YohDeadfall @TehPers
Fully qualified type name
6f20ecd 
Co-authored-by: TehPers <tehperz@gmail.com>
@cart
Copy link
Member

cart commented Apr 15, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 15, 2021
@YohDeadfall
Angle bracket annotated types to support generics (#1919)
2231492 
Fixes #1873. Types should be enclosed in angular brackets to avoid ambiquity and to correctly resolve associated functions.
@bors
Copy link
Contributor

bors bot commented Apr 15, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Angle bracket annotated types to support generics [Merged by Bors] - Angle bracket annotated types to support generics Apr 15, 2021
@bors bors bot closed this Apr 15, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@YohDeadfall @ostwilkens
Angle bracket annotated types to support generics (bevyengine#1919)
251ef82 
Fixes bevyengine#1873. Types should be enclosed in angular brackets to avoid ambiquity and to correctly resolve associated functions.
@YohDeadfall YohDeadfall deleted the bundle-generic-fields branch October 26, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TehPers TehPers TehPers approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deriving Bundle fails for nested bundles with generic parameters
4 participants
@YohDeadfall @cart @TehPers @alice-i-cecile