Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default button material behavior #1857

Closed
wants to merge 2 commits into from
Closed

Default button material behavior #1857

wants to merge 2 commits into from

Conversation

oldstork
Copy link

@oldstork oldstork commented Apr 8, 2021

Introduces a simple, customizable, and overridable default material behavior for buttons. Relevant examples are updated.

First time contributor here--I opened this PR because this is a behavior that I personally thought I would like when using Bevy. Feedback (even if negative--but hopefully not) is appreciated.

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Enhancement A new feature labels Apr 8, 2021
@alice-i-cecile
Copy link
Member

Welcome! This is a nice little change :) UI is currently slated for a complete overhaul for 0.6 (see #254); come hang out in Discord and on the pending RFC repo (#1662) if you'd like to be part of that process.

This PR is likely to sit in limbo until that's resolved, but it would be nice to rebase this once that's done <3

@cart cart added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 23, 2021
@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 24, 2021
@alice-i-cecile alice-i-cecile removed the C-Enhancement A new feature label May 2, 2022
@alice-i-cecile
Copy link
Member

Coming back to this, I think it's probably a bit too opinionated for a base button type. Closing this out, we can revisit it once we have a better idea of the widget design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants