[Merged by Bors] - Replace default method calls from Glam types with explicit const
#1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
the
C-Code-Quality
|
Good calls all around. Thanks! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2021
…1645) it's a followup of #1550 I think calling explicit methods/values instead of default makes the code easier to read: "what is `Quat::default()`" vs "Oh, it's `Quat::IDENTITY`" `Transform::identity()` and `GlobalTransform::identity()` can also be consts and I replaced the calls to their `default()` impl with `identity()`
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
default method calls from Glam types with explicit constdefault method calls from Glam types with explicit const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a followup of #1550
I think calling explicit methods/values instead of default makes the code easier to read: "what is
Quat::default()" vs "Oh, it'sQuat::IDENTITY"Transform::identity()andGlobalTransform::identity()can also be consts and I replaced the calls to theirdefault()impl withidentity()