[Merged by Bors] - convert grayscale images to rgb #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Assets
alice-i-cecile
approved these changes
Feb 26, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Good call! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
Fixes #1518 Issue was that images loaded as [`ImageLumaA8`](https://docs.rs/image/0.23.13/image/enum.DynamicImage.html#variant.ImageLumaA8) (grayscale with alpha channel) from `image` were considered as [`Rg8Unorm`](https://docs.rs/wgpu/0.7.0/wgpu/enum.TextureFormat.html#variant.Rg8Unorm) (red green channels) from `wgpu`. Same for `ImageLuma8` (grayscale) that was converted to `R8Unorm` (only red channel). As `wgpu` doesn't seem to have grayscale texture formats, I converted the grayscale textures to rgba.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
|
This seems like an odd change. Why force all 8bit grayscale images to rgba? It's rather unfortunate for heightmaps. The author of the issue had a simple solution and stated that "re-exporting [the png file] as an sRGB file solves the problem."
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1518
Issue was that images loaded as
ImageLumaA8(grayscale with alpha channel) fromimagewere considered asRg8Unorm(red green channels) fromwgpu.Same for
ImageLuma8(grayscale) that was converted toR8Unorm(only red channel).As
wgpudoesn't seem to have grayscale texture formats, I converted the grayscale textures to rgba.