[Merged by Bors] - Add suffixes to diagnostics and other cleanup #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a few related clean ups to diagnostics
DJMcNab
added
the
C-Usability
alice-i-cecile
approved these changes
Feb 22, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Looks good; this is a nice simple QoL improvement. |
mockersf
approved these changes
Feb 22, 2021
|
I dig it! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 3, 2021
Also a few related clean ups to diagnostics Old look (from the log_diagnostics_example): <details> <summary>Old look hidden to avoid clutter </summary>  </details> New look:  In particular, notice that the width of the diagnostics has been significantly reduced - within vscode the value no longer wraps on my 1920 width monitor. The value is still 105 columns wide, so there is room for improvement however.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a few related clean ups to diagnostics
Old look (from the log_diagnostics_example):
Old look hidden to avoid clutter
In particular, notice that the width of the diagnostics has been significantly reduced - within vscode the value no longer wraps on my 1920 width monitor. The value is still 105 columns wide, so there is room for improvement however.