Adds ShaderStorageBuffer asset
#14663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychedelia
added
A-Rendering
IceSentry
reviewed
Aug 8, 2024
|
See related old PR: #6669 |
JMS55
reviewed
Aug 19, 2024
IceSentry
reviewed
Aug 24, 2024
IceSentry
reviewed
Aug 24, 2024
IceSentry
reviewed
Aug 24, 2024
|
Like mentioned on discord. I'd prefer if this kept the ability to use a raw |
Adds a new `Handle<Storage>` asset type that can be used as a render asset, particularly for use with `AsBindGroup`.
tychedelia
force-pushed
the
13658-handle-storage
branch
from
cc1ca19
to
817b1f1
Compare
|
@IceSentry The refactor we did in #14909 helped clean this up a lot. Changes since you last reviewed:
|
IceSentry
reviewed
Aug 29, 2024
| @@ -0,0 +1,113 @@ | |||
| //! This example demonstrates how to use a storage buffer with `AsBindGroup` in a custom material. | |||
There was a problem hiding this comment.
Should the example be renamed to match the new type? I don't really have an opinion either way honestly.
There was a problem hiding this comment.
My thought was just that shader/shader_storage_buffer was a bit redundant.
There was a problem hiding this comment.
But happy to change :)
IceSentry
reviewed
Aug 29, 2024
IceSentry
approved these changes
Aug 29, 2024
|
Also, could you update the PR description with the new name? |
IceSentry
reviewed
Aug 29, 2024
IceSentry
reviewed
Aug 29, 2024
Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
Co-authored-by: IceSentry <IceSentry@users.noreply.github.com>
|
You added a new example but didn't add metadata for it. Please update the root Cargo.toml file. |
ChristopherBiscardi
approved these changes
Aug 31, 2024
IceSentry
added
S-Ready-For-Final-Review
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
…ata (#15044) Adds some methods to assist in building `ShaderStorageBuffer` without using `bytemuck`. We keep the `&[u8]` constructors since this is still modeled as a thin wrapper around the buffer descriptor, but should make it easier to interact with at the cost of an extra allocation in the `ShaderType` path for the buffer writer. Follow up from #14663
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
Handle<Storage>asset type that can be used as a render asset, particularly for use withAsBindGroup.Closes: #13658
Objective
Allow users to create storage buffers in the main world without having to access the
RenderDevice. While this resource is technically available, it's bad form to use in the main world and requires mixing rendering details with main world code. Additionally, this makes storage buffers easier to use withAsBindGroup, particularly in the following scenarios:VecAsBindGroupoption).Default. Previously, the lack of aDefaultimplement for the rawwgpu::Buffertype made implementing aAsBindGroup + Defaultbound difficult in the presence of buffers.Solution
Adds a new
Handle<Storage>asset type that is prepared into aGpuStorageBufferrender asset. This asset can either be initialized with aVec<u8>of properly aligned data or with a size hint. Users can modify the underlyingwgpu::BufferDescriptorto provide additional usage flags.Migration Guide
The
AsBindGroupstorageattribute has been modified to reference the newHandle<Storage>asset instead. Usages of Vec` should be converted into assets instead.