Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add to lower case to make asset loading case insensitive #1427

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - add to lower case to make asset loading case insensitive #1427

wants to merge 1 commit into from

Conversation

Archina
Copy link
Contributor

@Archina Archina commented Feb 10, 2021

This should fix bug #1425

@rparrett
Copy link
Contributor

Distill / atelier also behaves this way, so this seems like a good idea to me.

@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 17, 2021
Base automatically changed from master to main February 19, 2021 20:44
@cart
Copy link
Member

cart commented Mar 3, 2021

Good call!

@cart
Copy link
Member

cart commented Mar 3, 2021

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2021
@Archina
add to lower case to make asset loading case insensitive (#1427)
b8a0ab0 
This should fix bug #1425
@bors
Copy link
Contributor

bors bot commented Mar 3, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add to lower case to make asset loading case insensitive [Merged by Bors] - add to lower case to make asset loading case insensitive Mar 3, 2021
@bors bors bot closed this Mar 3, 2021
@alice-i-cecile alice-i-cecile mentioned this pull request Apr 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Archina @rparrett @cart @alice-i-cecile