Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture atlas format and conversion #1365

Merged
merged 6 commits into from
Feb 1, 2021
Merged

Texture atlas format and conversion #1365

merged 6 commits into from
Feb 1, 2021

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 1, 2021

fixes #553

  • adds a method to set the texture atlas format
  • automatic conversion into target format if needed. This can be disabled, in which case finishing the builder will return an error if there are different texture formats

cart
cart reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I just pushed a small change to increase code reuse in TextureAtlasBuilder

crates/bevy_sprite/src/texture_atlas_builder.rs Outdated Show resolved Hide resolved
@cart cart merged commit 6b8f8a7 into bevyengine:master Feb 1, 2021
@mockersf mockersf deleted the texture-atlas-format branch April 27, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpriteSheetComponent crashes when given grayscale PNG
2 participants
@mockersf @cart