Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compile test to use ui_test 0.23 #13245

Merged
merged 1 commit into from
May 5, 2024
Merged

Update compile test to use ui_test 0.23 #13245

merged 1 commit into from
May 5, 2024

Conversation

Brezak
Copy link
Contributor

@Brezak Brezak commented May 5, 2024

Objective

Closes #13241

Solution

Update test utils to use ui_test 0.23.0.

Testing

  • Run compile tests for bevy_ecs.

cc @BD103

BD103
BD103 approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it looks good, thanks for the quick work! I only have one nit about a confusing line of code (I'm assuming it is the replacement for dependencies_crate_manifest_path).

Cargo.toml Outdated Show resolved Hide resolved
tools/compile_fail_utils/src/lib.rs Show resolved Hide resolved
@BD103 BD103 added A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on X-Uncontroversial This work is generally agreed upon D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels May 5, 2024
mockersf
mockersf approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me with the comment on config.comment_defaults

@Brezak Brezak requested a review from BD103 May 5, 2024 16:20
BD103
BD103 approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI, and you're good to go!

@matiqo15 matiqo15 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 5, 2024
@mockersf mockersf added this pull request to the merge queue May 5, 2024
Merged via the queue into bevyengine:main with commit 423a473 May 5, 2024
32 checks passed
@Brezak Brezak deleted the ui-test-23 branch May 6, 2024 12:45
Brezak added a commit to Brezak/bevy that referenced this pull request May 7, 2024
@Brezak
Update release workflow pr body
cda43e6 
With bevyengine#13245 merged ui tests no longer specify dependency versions.
Revert the change to `release.yml` made in bevyengine#12810 as it's no longer required.
@Brezak Brezak mentioned this pull request May 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 12, 2024
@Brezak
Update release workflow pr body (#13274)
2a799ef 
# Objective

With #13245 merged ui tests no longer specify dependency versions.

## Solution

Revert the change to `release.yml` made in #12810 as it's no longer
required.

## Testing

- Merge.
- Wait for a release.
- Observe the release PR body.

cc @BD103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Dependencies A change to the crates that Bevy depends on D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ui_test to 0.23.0
4 participants
@Brezak @mockersf @BD103 @matiqo15