Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to request a redraw from an external source #12197

Merged
merged 5 commits into from
Mar 4, 2024
+24 −8
Merged

Add the ability to request a redraw from an external source #12197

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad6332c
trigger redraw on user event
RobinKellnerVector Feb 29, 2024
dc9e2dc
Merge branch 'main' into loop_from_external
R081n Mar 4, 2024
6b6e508
add explicit event type
RobinKellnerVector Mar 4, 2024
c7b8413
typo
RobinKellnerVector Mar 4, 2024
cf7343f
add documentation
RobinKellnerVector Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/bevy_winit/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ use winit::{
event_loop::{ControlFlow, EventLoop, EventLoopBuilder, EventLoopWindowTarget},
};

pub use winit::event_loop::EventLoopProxy;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it'd be nice to have some documentation pointing users to this pattern somewhere. Maybe on WinitSettings::desktop_app? Or maybe there's a better place for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, i added some documentation. I also added it to the bullet points of Reactive and ReactiveLowPower


use crate::accessibility::{AccessKitAdapters, AccessKitPlugin, WinitActionHandlers};

use crate::converters::convert_winit_theme;
Expand Down Expand Up @@ -690,6 +692,9 @@ fn handle_winit_event(
event_loop.set_control_flow(ControlFlow::Wait);
}
}
Event::UserEvent(_) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you expose a specific type that should be sent to trigger a redraw rather than match on anything?
Reusing https://docs.rs/bevy/latest/bevy/window/struct.RequestRedraw.html would be nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the type with RequestRedraw. Also the reexport is now a type alias which prevents someone from using the wrong generic parameter when requesting the resource

runner_state.redraw_requested = true;
}
_ => (),
}
}
Expand Down