Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Reflect for Exposure #11907

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Feb 16, 2024

Objective

  • Don't crash when loading a scene with a camera

Solution

  • Derive Reflect for Exposure

Closes #11905

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior labels Feb 16, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Feb 16, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 16, 2024
@alice-i-cecile
Copy link
Member

Merging as trivial, thank you!

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 16, 2024
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Merged via the queue into bevyengine:main with commit f81aa64 Feb 16, 2024
27 checks passed
@IceSentry IceSentry deleted the reflect-exposure branch April 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scene_viewer panics when given a gltf with a camera
3 participants