Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type to conviently lookup entities by name #11842

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add type to conviently lookup entities by name #11842

wants to merge 1 commit into from

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Feb 13, 2024 •
edited
Loading

Objective

Solution

  • Rebase and solve change conflicts.

@tygyh
Copy link
Contributor Author

tygyh commented Feb 13, 2024

When rebasing this I got stuck on which changes to take from this or #6785. I do not know who to ask for help with this.

@alice-i-cecile alice-i-cecile added A-Core Common functionality for all bevy apps A-Animation Make things move and change over time C-Usability A simple quality-of-life change that makes Bevy easier to use labels Feb 15, 2024
@alice-i-cecile
Copy link
Member

IMO you should add only the NameLookup in this PR: it'll be easier on merge conflicts and there's a good chance that @pcwalton's plan to avoid using names to lookup animations goes through.

@tygyh
Copy link
Contributor Author

tygyh commented Feb 19, 2024

I do not see a way to implement this because of the conflicts with #6785. Since there seems to be a different solution in the works by PCWalton I will leave this on hold for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Animation Make things move and change over time A-Core Common functionality for all bevy apps C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tygyh @alice-i-cecile @the10thWiz