fix(primitives): fix polygon gizmo rendering bug #11699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A logic error. The last linestring previously didn't close the polygon but added a zero length line at the last coordinate. Authored-by: RobWalt <robwalter96@gmail.com>
Jondolf
added
C-Bug
Jondolf
approved these changes
Feb 4, 2024
|
CI error seems unrelated and exists in other PRs too |
alice-i-cecile
approved these changes
Feb 4, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
CI please :( Seems to all be failure to fetch networking flakiness. |
lynn-lumen
pushed a commit
to lynn-lumen/bevy
that referenced
this pull request
Feb 5, 2024
This is just a minor fix extracted from bevyengine#11697 A logic error. We tried to close the polygon shape, if the user specifies an unclosed polygon. The closing linestring previously didn't close the polygon though, but instead added a zero length line at the last coordinate. Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
This is just a minor fix extracted from bevyengine#11697 A logic error. We tried to close the polygon shape, if the user specifies an unclosed polygon. The closing linestring previously didn't close the polygon though, but instead added a zero length line at the last coordinate. Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 14, 2024
I just implemented this to record a video for the new blog post, but I figured it would also make a good dedicated example. This also allows us to remove a lot of code from the 2d/3d gizmo examples since it supersedes this portion of code. Depends on: #11699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a minor fix extracted from #11697
A logic error. We tried to close the polygon shape, if the user specifies an
unclosed polygon. The closing linestring previously didn't close the polygon
though, but instead added a zero length line at the last coordinate.