Subtract 1 from text positions to account for glyph texture padding.

[ickshonpe]

Objective

Glyph positions don't account for padding added to the font texture atlas, resulting in them being off by one physical pixel in both axis.

Example

use bevy::{
    prelude::*, window::WindowResolution
};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins.set(WindowPlugin {
            primary_window: Some(Window {
                resolution: WindowResolution::default().with_scale_factor_override(1.),
                ..Default::default()
            }),
            ..Default::default()
        }))
        .add_systems(Startup, setup)
        .run();
}

fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
    commands.spawn(Camera2dBundle::default());
    commands.spawn(
        TextBundle::from_section(
            "QQQQQ",
            TextStyle {
                font: asset_server.load("FiraMono-Medium.ttf"),
                font_size: 14.0,
                ..default()
            },
        )
        .with_style(Style {
            left:Val::Px(10.),
            top: Val::Px(10.),
            ..default()
        })
        .with_background_color(Color::RED)
    );
}

The coordinates are off by one in physical coordinates, not logical. So the difference only becomes obvious with UiScale and the window scale factor set to low values.

Solution

Translate glyph positions by -1 in both axes.

---

Changelog

• Translate the positions for each glyph by -1 in both axes in bevy_text::glyph_brush::process_glyphs

[alice-i-cecile]

Once there's a comment added, this LGTM.