Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run examples on macOS to validate PRs #11630

Merged
merged 2 commits into from
Jan 31, 2024
Merged

run examples on macOS to validate PRs #11630

merged 2 commits into from
Jan 31, 2024

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Add a job to run examples on macOS when trying to merge a PR
  • Add a patch to disable audio in CI as it timeouts after 15 minutes on macOS, and fails anyway on the other runners

@mockersf mockersf added A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples O-MacOS Specific to the MacOS (Apple) desktop operating system labels Jan 31, 2024
alice-i-cecile
alice-i-cecile approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, this is a thing we should validate!

BD103
BD103 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Did you test this on a fork?

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 31, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 31, 2024
@mockersf
Copy link
Member Author

Awesome! Did you test this on a fork?

Yup, and there's already been two runs on all examples at https://thebevyflock.github.io/bevy-example-runner/index.html

It's possible I made a mistake when adapting to the workflow on this repo, but it should work

Merged via the queue into bevyengine:main with commit 76d32c9 Jan 31, 2024
24 checks passed
tjamaan pushed a commit to tjamaan/bevy that referenced this pull request Feb 6, 2024
@mockersf @tjamaan
run examples on macOS to validate PRs (bevyengine#11630)
40f43aa 
# Objective

- CI doesn't validate running examples on macOS
- GitHub now has free m1 runners with a virtualised GPU
https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

## Solution

- Add a job to run examples on macOS when trying to merge a PR
- Add a patch to disable audio in CI as it timeouts after 15 minutes on
macOS, and fails anyway on the other runners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@doonv doonv doonv approved these changes

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples O-MacOS Specific to the MacOS (Apple) desktop operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mockersf @alice-i-cecile @doonv @BD103