Fix cyclic dep #11523
Merged
Fix cyclic dep #11523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Jan 25, 2024
|
Does this fix #10256 perhaps? |
It does for me. |
rparrett
added
the
S-Ready-For-Final-Review
doonv
approved these changes
Jan 25, 2024
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective Rust analyzer kept complaining about a cyclic dependency due to `bevy_input` having a dev-dependency on `bevy`. `bevy_input` was also missing `bevy_reflect`'s "smol_str" feature which it needs to compile on its own. Fixes bevyengine#10256 ## Solution Remove the dev-dependency on `bevy` from `bevy_input` since it was only used to reduce imports for 1 test and 3 doc examples by 1 line each, as `bevy_input` already has dependencies on everything needed for those tests and doctests to work. Add `bevy_reflect`'s "smol_str" feature to `bevy_input`'s dependency list as it needs it to actually compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Rust analyzer kept complaining about a cyclic dependency due to
bevy_inputhaving a dev-dependency onbevy.bevy_inputwas also missingbevy_reflect's "smol_str" feature which it needs to compile on its own.Fixes #10256
Solution
Remove the dev-dependency on
bevyfrombevy_inputsince it was only used to reduce imports for 1 test and 3 doc examples by 1 line each, asbevy_inputalready has dependencies on everything needed for those tests and doctests to work.Add
bevy_reflect's "smol_str" feature tobevy_input's dependency list as it needs it to actually compile.