Include asset path in get_meta_path panic message #11504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
doonv
reviewed
Jan 24, 2024
alice-i-cecile
added
A-Assets
Co-authored-by: Doonv <58695417+doonv@users.noreply.github.com>
alice-i-cecile
approved these changes
Jan 24, 2024
doonv
approved these changes
Jan 25, 2024
mockersf
approved these changes
Jan 25, 2024
mockersf
added
the
S-Ready-For-Final-Review
tjamaan
pushed a commit
to tjamaan/bevy
that referenced
this pull request
Feb 6, 2024
# Objective - Fixes a hurdle encountered when debugging a panic caused by the file watcher loading a `.gitignore` file, which was hard to debug because there was no file name in the report, only `asset paths must have extensions` ## Solution - Panic with a formatted message that includes the asset path, e.g. `missing expected extension for asset path .gitignore` --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Doonv <58695417+doonv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
.gitignorefile, which was hard to debug because there was no file name in the report, onlyasset paths must have extensionsSolution
missing expected extension for asset path .gitignore