Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore brightness in the remaining three examples after exposure PR #11389

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

GitGhillie
Copy link
Contributor

Objective

Fixes #11376
During the development of the exposure settings PR (#11347) all examples with lighting had to be adjusted, but three were missed or simply didn't exist yet at the time. This PR restores the brightness in those examples again:

render_ui_to_texture
asset_loading
hot_asset_reloading

All of them are a bit brighter now compared to before the exposure PR, but it looks better IMO.

Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples labels Jan 17, 2024
@alice-i-cecile alice-i-cecile added this to the 0.13 milestone Jan 17, 2024
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should we adjust the default PointLight intensity to something more reasonable?

@GitGhillie
Copy link
Contributor Author

@fintelia had some thoughts on that here: #8407 (comment)
And here my thoughts after adjusting all the examples: #8407 (comment)

I didn't explicitly mention that I also felt like increasing the default PointLight intensity but I'd be down to adjust all the necessary examples again if people agree! Though, in a different PR maybe?

@alice-i-cecile
Copy link
Member

Okay, happy to leave this then. Merging as trivial :)

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 17, 2024
Merged via the queue into bevyengine:main with commit 9abf565 Jan 17, 2024
25 checks passed
@GitGhillie GitGhillie deleted the forgotten-examples branch January 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some examples need tweaks after new exposure settings
2 participants