Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create serialize feature for bevy_ui #11188

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

pablo-lua
Copy link
Contributor

Objective

Solution

  • Creation of the serialize feature to ui

Changelog

Changed

  • Changed all the structs that implement Serialize and Deserialize to only implement when feature is on

Migration Guide

  • If you want to use serialize and deserialize with types from bevy_ui, you need to use the feature serialize in your TOML
[dependencies.bevy]
features = ["serialize"]

@pablo-lua pablo-lua changed the title Create serialize feature Create serialize feature for bevy_ui Jan 3, 2024
@pablo-lua
Copy link
Contributor Author

pablo-lua commented Jan 3, 2024

There is probably something missing here and there with the reflect. Noticed that some structs have Default and do not reflect it. Well, didn't touch it for now

@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change labels Jan 3, 2024
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 3, 2024
Merged via the queue into bevyengine:main with commit 41c3620 Jan 3, 2024
30 checks passed
@pablo-lua pablo-lua deleted the create_serialize_feature branch February 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a feature to Serialize in bevy_ui
3 participants