Publish dev-docs with Github Pages artifacts (2nd attempt) #10892
Conversation
I'm getting a permissions error when trying to publish the docs. I'm hoping downgrading will fix it.
alice-i-cecile
added
A-Build-System
alice-i-cecile
changed the title
|
@mockersf would you mind reviewing this PR? |
| # Only allow one deployment to run at a time, however it will not cancel in-progress runs. | ||
| concurrency: | ||
| group: "pages" | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
why this choice? Cancelling would make sense here, we only care about the last version
There was a problem hiding this comment.
In the example for using pages artifacts, the following comment is provided about the concurrency setting:
# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.My best guess is that perhaps cancelling the deploy job while it's still uploading to Github pages could be bad, but I've never tested it. (See docs on concurrency.)
I think it would be best to leave this. The developer docs don't seem like a time-sensitive thing. If this is a risk of messing up Github pages, I don't think it's worth the couple of extra minutes saved.
There was a problem hiding this comment.
Not a fan of adding that for now, but it doesn't really matter
|
Thank you! Could you please make sure to switch the GitHub pages setting for the repo so it uses the artifact when this gets merged? |
|
@alice-i-cecile could you please review this? (Thanks!) |
alice-i-cecile
added
the
S-Ready-For-Final-Review
Supersedes #10888.
Objective
Closes #10821
Solution
Notes
workflow_dispatch), in case something goes wrong.