Print precise and correct watch warnings (and only when necessary) #10787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cart
added
C-Bug
alice-i-cecile
approved these changes
Nov 28, 2023
cart
added a commit
that referenced
this pull request
Nov 30, 2023
…10787) # Objective Fixes #10401 ## Solution * Allow sources to register specific processed/unprocessed watch warnings. * Specify per-platform watch warnings. This removes the need to cover all platform cases in one warning message. * Only register watch warnings for the _processed_ embedded source, as warning about watching unprocessed embedded isn't helpful. --- ## Changelog - Asset sources can now register specific watch warnings.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Dec 1, 2023
…evyengine#10787) # Objective Fixes bevyengine#10401 ## Solution * Allow sources to register specific processed/unprocessed watch warnings. * Specify per-platform watch warnings. This removes the need to cover all platform cases in one warning message. * Only register watch warnings for the _processed_ embedded source, as warning about watching unprocessed embedded isn't helpful. --- ## Changelog - Asset sources can now register specific watch warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #10401
Solution
Changelog