Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran cargo fmt on benches crate #10758

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

bushrat011899
Copy link
Contributor

Objective

  • Format benches crate to match current Rust standards.

Solution

  • Ran cargo fmt in the benches crate.

Notes

I accidentally came across this when working on the Drop implementation for CommandQueue and rather embarrassingly let it sneak into my PR there. I think it makes sense to ensure this crate is also well formatted to avoid it in the future.

Style guide must've changed since the last time it was run.
@ItsDoot ItsDoot added the C-Code-Quality A section of code that is hard to understand or change label Nov 27, 2023
Copy link
Contributor

@rlidwka rlidwka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This is what we have to do, otherwise someone else is gonna run into this eventually.

Additionally, from the Bevy side, this should be checked by CI.

And from rustfmt side, it shouldn't touch irrelevant files in your PR. Unfortunately, feature request to do that is open over there for almost 7 years now. :(

@bushrat011899
Copy link
Contributor Author

And from rustfmt side, it shouldn't touch irrelevant files in your PR. Unfortunately, feature request to do that is open over there for almost 7 years now. :(

Correct! I accidentally ran cargo fmt whilst still in the benches crate, which is how I noticed this was a problem.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Nov 27, 2023
Merged via the queue into bevyengine:main with commit 52c11f6 Nov 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants