do not check for focus until cursor position has been set #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
C-Bug
|
I dig this. Now that we store the cursor_position in the window, I think it makes sense to simplify the focus impl. I just pushed a commit that does that. |
|
(feel free to comment on that though, we can always drop the commit) |
mockersf
commented
Dec 22, 2020
| } | ||
| let cursor_position = if let Some(cursor_position) = windows | ||
| .get_primary() | ||
| .and_then(|window| window.cursor_position()) |
There was a problem hiding this comment.
will that work when having multiple windows? anyway did it even work before with multiple windows?
There was a problem hiding this comment.
It didn't filter according to WindowId, so it would have supported multiple windows for focus events. But the rest of the UI system doesn't support multiple windows, so it doesn't really matter. If/when that ever gets built we can use the same approach here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1036
how to see the issue: in example button.rs, comment this line, the button will be displayed in the bottom left corner with "Hover" state
this is because the mouse position in the local resource for the
ui_focus_systemis created with(0,0).This PR wraps the
cursor_positionin the local state in an option, and do not compute focus if this option isNone