Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use minor and major radii for Torus primitive shape #10643

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Use minor and major radii for Torus primitive shape #10643

merged 12 commits into from
Nov 21, 2023

Commits on Nov 19, 2023

  1. Use minor and major radii for Torus shape representation

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    a528d00 View commit details
    Browse the repository at this point in the history

  2. Add TorusKind enum

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    d163438 View commit details
    Browse the repository at this point in the history

  3. Add derives for TorusKind

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    c1811ca View commit details
    Browse the repository at this point in the history

  4. Inline Torus methods and add inner/outer radius formulae

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    8b4edf0 View commit details
    Browse the repository at this point in the history

  5. Use partial_cmp and add a Panics section for Torus::kind

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b9437bb View commit details
    Browse the repository at this point in the history

  6. must_use torus methods

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    ffa5ad0 View commit details
    Browse the repository at this point in the history

  7. Assert positive minor/major radii for torus

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    9f54788 View commit details
    Browse the repository at this point in the history

  8. Remove assert

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    c8d7be1 View commit details
    Browse the repository at this point in the history

  9. Add TorusKind::Invalid

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    4653ffa View commit details
    Browse the repository at this point in the history

  10. Return TorusKind::Invalid for NaN

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f66d486 View commit details
    Browse the repository at this point in the history

  11. Oxford comma

    @Jondolf
    Jondolf committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    2d3586b View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Remove must_use

    @Jondolf
    Jondolf committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    4f4f1e0 View commit details
    Browse the repository at this point in the history