Reexport wgpu::Maintain
#10461
Merged
Reexport wgpu::Maintain
#10461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Nov 8, 2023
james7132
approved these changes
Nov 9, 2023
alice-i-cecile
added
A-Rendering
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Calling `RenderDevice::poll` requires an instance of `wgpu::Maintain`, but the type was not reexported by bevy. Working around it requires adding a dependency on `wgpu`, since bevy does not reexport the `wgpu` crate as a whole anywhere. ## Solution Reexport `wgpu::Maintain` in `render_resource`, where the other wgpu types are reexported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Calling
RenderDevice::pollrequires an instance ofwgpu::Maintain, but the type was not reexported by bevy. Working around it requires adding a dependency onwgpu, since bevy does not reexport thewgpucrate as a whole anywhere.Solution
Reexport
wgpu::Maintaininrender_resource, where the other wgpu types are reexported.