Rename Time::<Fixed>::overstep_percentage() and Time::<Fixed>::overstep_percentage_f64()
#10448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…step_fraction()`
…overstep_fraction_f64()`
alice-i-cecile
added
C-Usability
alice-i-cecile
approved these changes
Nov 8, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
|
Merging with #10442. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…rstep_percentage_f64()` (bevyengine#10448) # Objective This is similar to bevyengine#10439. `Time::<Fixed>::overstep_percentage()` and `Time::<Fixed>::overstep_percentage_f64()` returns values from 0.0 to 1.0, but their names use the word "percentage". These function names make it easy to misunderstand that they return values from 0.0 to 100.0. To avoid confusion, these functions should be renamed to "`overstep_fraction(_f64)`". ## Solution Rename them. --- ## Changelog ### Changed - Renamed `Time::<Fixed>::overstep_percentage()` to `Time::<Fixed>::overstep_fraction()` - Renamed `Time::<Fixed>::overstep_percentage_f64()` to `Time::<Fixed>::overstep_fraction_f64()` ## Migration Guide - `Time::<Fixed>::overstep_percentage()` has been renamed to `Time::<Fixed>::overstep_fraction()` - `Time::<Fixed>::overstep_percentage_f64()` has been renamed to `Time::<Fixed>::overstep_fraction_f64()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This is similar to #10439.
Time::<Fixed>::overstep_percentage()andTime::<Fixed>::overstep_percentage_f64()returns values from 0.0 to 1.0, but their names use the word "percentage". These function names make it easy to misunderstand that they return values from 0.0 to 100.0.To avoid confusion, these functions should be renamed to "
overstep_fraction(_f64)".Solution
Rename them.
Changelog
Changed
Time::<Fixed>::overstep_percentage()toTime::<Fixed>::overstep_fraction()Time::<Fixed>::overstep_percentage_f64()toTime::<Fixed>::overstep_fraction_f64()Migration Guide
Time::<Fixed>::overstep_percentage()has been renamed toTime::<Fixed>::overstep_fraction()Time::<Fixed>::overstep_percentage_f64()has been renamed toTime::<Fixed>::overstep_fraction_f64()