Implement Clone for VisibilityBundle and SpatialBundle #10394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good call, I Implemented |
doonv
changed the title
alice-i-cecile
approved these changes
Nov 5, 2023
JoJoJet
approved these changes
Nov 6, 2023
JMS55
approved these changes
Nov 6, 2023
alice-i-cecile
added
A-Rendering
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Huh, why did it fail building wasm? |
|
Looks like a semver violating change / new bug in one of our dependencies :( We may need to pin async_executor: smol-rs/async-executor#72 (thanks @Bluefinger). |
james7132
approved these changes
Nov 7, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
) # Objective Had an issue where I had `VisibilityBundle` inside a bundle that implements `Clone`, but since `VisibilityBundle` doesn't implement `Clone` that wasn't possible. This PR fixes that. ## Solution Implement `Clone` for `VisibilityBundle` by deriving it. And also `SpatialBundle` too because why not. --- ## Changelog - Added implementation for `Clone` on `VisibilityBundle` and `SpatialBundle`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Had an issue where I had
VisibilityBundleinside a bundle that implementsClone, but sinceVisibilityBundledoesn't implementClonethat wasn't possible. This PR fixes that.Solution
Implement
CloneforVisibilityBundleby deriving it. And alsoSpatialBundletoo because why not.Changelog
CloneonVisibilityBundleandSpatialBundle.