Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frustum to shader View #10306

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Add frustum to shader View #10306

merged 4 commits into from
Oct 31, 2023

Conversation

JMS55
Copy link
Contributor

@JMS55 JMS55 commented Oct 29, 2023

Objective

Solution

  • Pass the view frustum to the shader view uniform

Changelog

  • View Frustums are now extracted to the render world and made available to shaders

@JMS55 JMS55 added C-Enhancement A new feature A-Rendering Drawing game state to the screen labels Oct 29, 2023
@JMS55 JMS55 added this to the 0.13 milestone Oct 29, 2023
IceSentry
IceSentry approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 29, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 31, 2023
Merged via the queue into bevyengine:main with commit 3628e09 Oct 31, 2023
22 checks passed
@Mathspy
Copy link

Mathspy commented Nov 3, 2023

I think this is part of the 0.12 milestone since it will be going out with the release, right?

@mockersf mockersf removed this from the 0.13 milestone Nov 3, 2023
@mockersf
Copy link
Member

mockersf commented Nov 3, 2023

yup

ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@JMS55 @ameknite
Add frustum to shader View (bevyengine#10306)
894a704 
# Objective
- Work towards GPU-driven culling
(bevyengine#10164)

## Solution
- Pass the view frustum to the shader view uniform

---

## Changelog
- View Frustums are now extracted to the render world and made available
to shaders
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@JMS55
Add frustum to shader View (bevyengine#10306)
afd1d98 
# Objective
- Work towards GPU-driven culling
(bevyengine#10164)

## Solution
- Pass the view frustum to the shader view uniform

---

## Changelog
- View Frustums are now extracted to the render world and made available
to shaders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Enhancement A new feature S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JMS55 @Mathspy @mockersf @james7132 @alice-i-cecile @IceSentry