Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make deferred_rendering simpler to render for CI #10150

Merged
merged 1 commit into from
Oct 28, 2023
Merged

make deferred_rendering simpler to render for CI #10150

merged 1 commit into from
Oct 28, 2023

Conversation

mockersf
Copy link
Member

Objective

  • Example deferred_rendering sometimes fail to render in CI
  • Make it easier to render

Solution

  • Reduce the complexity of the sphere used

@mockersf mockersf added A-Build-System Related to build systems or continuous integration C-Examples An addition or correction to our examples labels Oct 16, 2023
@alice-i-cecile alice-i-cecile added the A-Rendering Drawing game state to the screen label Oct 16, 2023
@alice-i-cecile
Copy link
Member

Poor CI :(

@james7132 james7132 added this pull request to the merge queue Oct 28, 2023
Merged via the queue into bevyengine:main with commit 5d44d2a Oct 28, 2023
25 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
make deferred_rendering simpler to render for CI (bevyengine#10150)
7580b3c 
# Objective

- Example `deferred_rendering` sometimes fail to render in CI
- Make it easier to render

## Solution

- Reduce the complexity of the sphere used
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
make deferred_rendering simpler to render for CI (bevyengine#10150)
916fd88 
# Objective

- Example `deferred_rendering` sometimes fail to render in CI
- Make it easier to render

## Solution

- Reduce the complexity of the sphere used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @alice-i-cecile @james7132