Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only set up processed source if asset plugin is not unprocessed #10123

Merged
merged 2 commits into from
Oct 15, 2023
Merged

only set up processed source if asset plugin is not unprocessed #10123

merged 2 commits into from
Oct 15, 2023

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Oct 14, 2023 •
edited
Loading

Objective

  • Since Multiple Asset Sources #9885, running on an iOS device crashes trying to create the processed folder
  • This only happens on real device, not on the simulator

Solution

  • Setup processed assets only if needed

@mockersf mockersf added A-Assets Load files from disk to use for things like images, models, and sounds O-iOS Specific to the iOS mobile operating system labels Oct 14, 2023
@mockersf mockersf added this to the 0.12 milestone Oct 14, 2023
@mockersf mockersf requested a review from cart October 14, 2023 21:20
@cart cart added this pull request to the merge queue Oct 15, 2023
Merged via the queue into bevyengine:main with commit 5781806 Oct 15, 2023
21 checks passed
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@mockersf @ameknite
only set up processed source if asset plugin is not unprocessed (bevy…
a8f92d7 
…engine#10123)

# Objective

- Since bevyengine#9885, running on an iOS device crashes trying to create the
processed folder
- This only happens on real device, not on the simulator

## Solution

- Setup processed assets only if needed
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@mockersf
only set up processed source if asset plugin is not unprocessed (bevy…
4fcacbf 
…engine#10123)

# Objective

- Since bevyengine#9885, running on an iOS device crashes trying to create the
processed folder
- This only happens on real device, not on the simulator

## Solution

- Setup processed assets only if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Assets Load files from disk to use for things like images, models, and sounds O-iOS Specific to the iOS mobile operating system
Projects
@cart's attention
Status: Responded
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@mockersf @cart