Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for rust 1.73 #10035

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Updates for rust 1.73 #10035

merged 3 commits into from
Oct 6, 2023

Conversation

hymm
Copy link
Contributor

@hymm hymm commented Oct 5, 2023

Objective

  • Updates for rust 1.73

Solution

  • new doc check for redundant_explicit_links
  • updated to text for compile fail tests

Changelog

  • updates for rust 1.73

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 5, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 6, 2023
Merged via the queue into bevyengine:main with commit 687e379 Oct 6, 2023
22 checks passed
@hymm hymm deleted the update-rust-1.73 branch October 6, 2023 16:01
@s-puig
Copy link
Contributor

s-puig commented Oct 6, 2023

@hymm Is there a definite fix for 715290d revert?
CI is working properly on Actions but appears broken on my system.

@mockersf
Copy link
Member

mockersf commented Oct 6, 2023

this is #8962, and no fix. For some it works, for some it doesn't, and we haven't spotted yet the reason why

regnarock pushed a commit to regnarock/bevy that referenced this pull request Oct 13, 2023
@hymm
Updates for rust 1.73 (bevyengine#10035)
6f2adb7 
# Objective

- Updates for rust 1.73

## Solution

- new doc check for `redundant_explicit_links`
- updated to text for compile fail tests

---

## Changelog

- updates for rust 1.73
ameknite pushed a commit to ameknite/bevy that referenced this pull request Nov 6, 2023
@hymm @ameknite
Updates for rust 1.73 (bevyengine#10035)
e966e4e 
# Objective

- Updates for rust 1.73

## Solution

- new doc check for `redundant_explicit_links`
- updated to text for compile fail tests

---

## Changelog

- updates for rust 1.73
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@hymm
Updates for rust 1.73 (bevyengine#10035)
44c1ce7 
# Objective

- Updates for rust 1.73

## Solution

- new doc check for `redundant_explicit_links`
- updated to text for compile fail tests

---

## Changelog

- updates for rust 1.73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hymm @s-puig @mockersf @alice-i-cecile