Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up doc string in NodeBundle #9440

Closed
alice-i-cecile opened this issue Aug 14, 2023 · 1 comment · Fixed by #9481
Closed

Clean up doc string in NodeBundle #9440

alice-i-cecile opened this issue Aug 14, 2023 · 1 comment · Fixed by #9481
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member 

          There's also a copy of this "`NodeBundle`" comment here, associated with the `node` field, with the same copy/paste mistake.

Seems safe to get rid of this one too to me. Not every bundle has it. But maybe it was intended that it say "to alter the size"?

Originally posted by @rparrett in #9404 (comment)
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets labels Aug 14, 2023
@hate
Copy link
Contributor

hate commented Aug 18, 2023

Considering that the doc string for the style component already mentions adjusting the size and position of the ImageBundle, I'd concur that the aforementioned string should be removed.

@hate hate mentioned this issue Aug 18, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2023
@hate
Remove unnecessary doc string (#9481)
ee0f2a7 
# Objective

- Resolves #9440

## Solution

- Remove the doc string mentioning the position of a `NodeBundle`, since
the doc string for the `style` component already explains this ability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary doc string hate/bevy
2 participants
@alice-i-cecile @hate