Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default window title leaks "bevy" context #9298

Closed
ickk opened this issue Jul 29, 2023 · 3 comments · Fixed by #9301
Closed

Default window title leaks "bevy" context #9298

ickk opened this issue Jul 29, 2023 · 3 comments · Fixed by #9301
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Regression Functionality that used to work but no longer does. Add a test for this! D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@ickk
Copy link
Member

ickk commented Jul 29, 2023 •
edited
Loading

The default window title is "bevy app" but should be just "app".

This decision was made in #3404 (comment) and was later patched in #3417.

However there was a small regression when moving to windows-as-entities #5589.

Leaking small details like this can look a little bit unprofessional for applications.
@ickk ickk added D-Trivial Nice and easy! A great choice to get started with Bevy A-Windowing Platform-agnostic interface layer to run your app in C-Regression Functionality that used to work but no longer does. Add a test for this! labels Jul 29, 2023
@DDiekmann
Copy link

I would like to work on this as my first contribution, if that is okay?

@floreal
Copy link
Contributor

floreal commented Jul 29, 2023

Oh, I am about to submit my PR. Do you want me to leave it to you ?

@DDiekmann
Copy link

Thanks, but that's fine. I'll find something else.

@floreal floreal mentioned this issue Jul 29, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2023
@floreal
Fixed: Default window is now "App" instead of "Bevy App" (#9301)
2515593 
# Objective

Fixes #9298 - Default window title leaks "bevy" context

## Solution

I just replaced the literal string "Bevy App" with "App" in Window's
Default trait implementation.
cart pushed a commit that referenced this issue Aug 10, 2023
@floreal @cart
Fixed: Default window is now "App" instead of "Bevy App" (#9301)
bda987d 
# Objective

Fixes #9298 - Default window title leaks "bevy" context

## Solution

I just replaced the literal string "Bevy App" with "App" in Window's
Default trait implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Regression Functionality that used to work but no longer does. Add a test for this! D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: Default window is now "App" instead of "Bevy App" floreal/bevy
3 participants
@floreal @ickk @DDiekmann