Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bevy logo has disapeared from the ui.rs example #8805

Closed
nicopap opened this issue Jun 10, 2023 · 1 comment · Fixed by #7894
Closed

bevy logo has disapeared from the ui.rs example #8805

nicopap opened this issue Jun 10, 2023 · 1 comment · Fixed by #7894
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples

Comments

@nicopap
Copy link
Contributor

nicopap commented Jun 10, 2023

It seems commit #6874 removed the image field at line 278 of the ui.rs example, and we don't see the bevy logo anymore in the example, even though there is a comment alleging the opposite.

Just adding back the line doesn't seem enough though. It's all flattened, and the label text displays with the image.

                        image: asset_server.load("branding/bevy_logo_dark_big.png").into(),
@nicopap nicopap added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples labels Jun 10, 2023
nicopap added a commit to nicopap/bevy that referenced this issue Jun 10, 2023
@ickshonpe
Copy link
Contributor

ickshonpe commented Jun 10, 2023

It was broken by the alt-text implementation.
If UI nodes with a MeasureFunc (ImageBundle and TextBundle) have children then the layout algorithm ignores the MeasureFunc and derives the size of the node from the style properties like for a normal UI node.

I opened an issue about alt-text at #7928 and there was a discussion at #7894.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
2 participants