Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove render feature group #5753

Closed
Shatur opened this issue Aug 20, 2022 · 2 comments
Closed

Remove render feature group #5753

Shatur opened this issue Aug 20, 2022 · 2 comments
Labels
A-App Bevy apps and plugins C-Enhancement A new feature C-Usability A simple quality-of-life change that makes Bevy easier to use

Comments

@Shatur
Copy link
Contributor

Shatur commented Aug 20, 2022 •
edited
Loading

What problem does this solve or what need does it fill?

Almost every Bevy plugin use render feature group by mistake. It pulls bevy_ui, bevy_sprite and a lot of other plugins. I did so many PRs for third party crates that fixed this 😄
For how many crates made this mistake see references to #4202

What solution would you like?

I would remove this feature group. We already have default feature which provides full engine experience.
@Shatur Shatur added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Aug 20, 2022
@Weibye Weibye added C-Usability A simple quality-of-life change that makes Bevy easier to use A-App Bevy apps and plugins and removed S-Needs-Triage This issue needs to be labelled labels Aug 21, 2022
@Nilirad
Copy link
Contributor

Nilirad commented Aug 21, 2022

I agree, but we need to document all those rendering features, so people can choose what they need.

This was referenced Aug 21, 2022
Merged
Closed
@Shatur Shatur mentioned this issue Dec 10, 2022
Merged
@mockersf
Copy link
Member

I agree too 👍

@Shatur Shatur mentioned this issue Dec 11, 2022
Closed
@james7132 james7132 mentioned this issue Dec 11, 2022
Open
@bors bors bot closed this as completed in 5447768 Dec 11, 2022
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@Shatur @alradish
Remove render feature group (bevyengine#6912)
db38ea4 
# Objective

The feature doesn't have any use case in libraries or applications and many users use this feature incorrectly. See the issue for details.
Closes bevyengine#5753.

## Solution

Remove it.

---

## Changelog

### Removed

- `render` feature group. 

## Migration Guide

Instead of using `render` feature group use dependencies directly. This group consisted of `bevy_core_pipeline`, `bevy_pbr`, `bevy_gltf`, `bevy_render`, `bevy_sprite`, `bevy_text` and `bevy_ui`. You probably want to check if you need all of them.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@Shatur @ItsDoot
Remove render feature group (bevyengine#6912)
959e7cd 
# Objective

The feature doesn't have any use case in libraries or applications and many users use this feature incorrectly. See the issue for details.
Closes bevyengine#5753.

## Solution

Remove it.

---

## Changelog

### Removed

- `render` feature group. 

## Migration Guide

Instead of using `render` feature group use dependencies directly. This group consisted of `bevy_core_pipeline`, `bevy_pbr`, `bevy_gltf`, `bevy_render`, `bevy_sprite`, `bevy_text` and `bevy_ui`. You probably want to check if you need all of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Enhancement A new feature C-Usability A simple quality-of-life change that makes Bevy easier to use
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Remove render feature group projectharmonia/bevy
4 participants
@mockersf @Weibye @Shatur @Nilirad