Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary usages of WorldCell API #5109

Closed
alice-i-cecile opened this issue Jun 26, 2022 · 0 comments
Closed

Remove unnecessary usages of WorldCell API #5109

alice-i-cecile opened this issue Jun 26, 2022 · 0 comments
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

Per #3939, there are a number of places in the code base where WorldCell (used to get split mutable access to the World) is used but is not needed.

This leads to pointlessly panic-prone code that will be slower, harder to read and more blocking.

To complete this issue, extract and rebase the changes from #3939 (other than removing the WorldCell API).
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Jun 26, 2022
@alice-i-cecile alice-i-cecile mentioned this issue Jun 26, 2022
Closed
@SarthakSingh31 SarthakSingh31 mentioned this issue Jul 1, 2022
Closed
@bors bors bot closed this as completed in cdbabb7 Jul 1, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this issue Aug 8, 2022
@SarthakSingh31 @inodentry
Removed world cell from places where split multable access is not nee…
69ece68 
…ded (bevyengine#5167)

Fixes bevyengine#5109.
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@SarthakSingh31 @james7132
Removed world cell from places where split multable access is not nee…
43525fb 
…ded (bevyengine#5167)

Fixes bevyengine#5109.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@SarthakSingh31 @ItsDoot
Removed world cell from places where split multable access is not nee…
d82fea0 
…ded (bevyengine#5167)

Fixes bevyengine#5109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
1 participant
@alice-i-cecile