Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some examples do not work under the new renderer #3379

Closed
nicopap opened this issue Dec 19, 2021 · 3 comments
Closed

Some examples do not work under the new renderer #3379

nicopap opened this issue Dec 19, 2021 · 3 comments
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Milestone
Bevy 0.6

Comments

@nicopap
Copy link
Contributor

nicopap commented Dec 19, 2021 •
edited
Loading

Environment

  • Bevy version: commit #340957994 (main as of Dec 19 2021)
  • OS & graphic stack: ArchLinux kernel 5.15.4; mesa/vulkan-radeon lib: v21.3.1; GPU: AMD ATI Radeon RX 5600

Bug

The following examples do not render things on screen as expected:

  • shader_material: Shows a gray screen with 8 green points forming the vertexes of a cube
  • shader_def: Just show a default gray window
  • shadow_biases: Shows a very interesting Moiré pattern with very pixelated shadows on the plane
  • wireframe: I see the default 3d_scene but the vertexes are a green pixel

Note: Other examples seem to work as intended.

Screenshots

Wireframe

Screenshot_12-19_10-27

shader_material

Screenshot_12-19_10-28

shadow_biases

Screenshot_12-19_10-30

More precision. I moved the camera and the shadows look way better. I do not see the same artifacts, though there is still more subtle artifacts such as a black grind on top of the plane.

shader_def

just a gray square.
@nicopap nicopap added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 19, 2021
@Davier
Copy link
Contributor

Davier commented Dec 19, 2021

The issues with wireframe, shader_material and shader_defs seem to be introduced by #3349

@nicopap
Copy link
Contributor Author

nicopap commented Dec 19, 2021

Can confirm, those three examples work on my machine on commit #6eb8e15e3d34f1c4171

@Davier
Copy link
Contributor

Davier commented Dec 19, 2021

The issue is that we need to specialize the pipeline for each entity in the queue_* functions, I'm working on a fix.

@Davier Davier mentioned this issue Dec 19, 2021
Closed
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples S-Needs-Investigation This issue requires detective work to figure out what's going wrong and removed S-Needs-Triage This issue needs to be labelled labels Dec 19, 2021
@alice-i-cecile alice-i-cecile added this to the Bevy 0.6 milestone Dec 19, 2021
@alice-i-cecile alice-i-cecile removed the S-Needs-Investigation This issue requires detective work to figure out what's going wrong label Dec 19, 2021
@bors bors bot closed this as completed in c79ec9c Dec 20, 2021
mockersf pushed a commit to mockersf/bevy that referenced this issue Dec 21, 2021
@Davier @cart @mockersf
Fix custom mesh pipelines (bevyengine#3381)
45a7231 
# Objective

Fixes bevyengine#3379 

## Solution

The custom mesh pipelines needed to be specialized on each mesh's primitive topology, as done in `queue_meshes()`

Co-authored-by: Carter Anderson <mcanders1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix custom mesh pipelines Davier/bevy
3 participants
@Davier @alice-i-cecile @nicopap