Can't change default image sampler - DefaultImageSampler tuple field is pub(crate)

[sarkahn]

Bevy version

main

What went wrong

We now have the DefaultImageSampler resource, which I would have thought is a way for users to specify a different default sampler for new sprites. However because the tuple field is pub(crate) we have no way to actually change the resource externally.

If we're not meant to change this resource why is it publicly visible?

[DJMcNab]

You should set the default_sampler field on ImageSettings.

The DefaultImageSampler gets set based on that:

bevy/crates/bevy_render/src/texture/mod.rs

Lines 73 to 76 in 8b27124

	let default_sampler = {
	let device = render_app.world.resource::<RenderDevice>();
	device.create_sampler(&default_sampler)
	};

Notice that ImageSettings is a main world resource, whereas DefaultImageSampler is a render world resource.

[sarkahn]

Great, thanks! I'm wondering if the documentation for DefaultImageSampler should say something to that effect?

[sarkahn]

Also the documentation for ImageSampler should probably reflect this as well. It mentions DefaultImageSampler but no mention of ImageSettings - the actual resource used to change the default.

[DJMcNab]

That would be because the change to DefaultImageSampler was one of @cart's 'drive-by' changes, which didn't get reviewed in light of the rest of the PR. A fix would be welcome.