Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gamepad viewer example no longer on website #726

Closed
paul-hansen opened this issue Aug 5, 2023 · 5 comments
Closed

Gamepad viewer example no longer on website #726

paul-hansen opened this issue Aug 5, 2023 · 5 comments

Comments

@paul-hansen
Copy link
Contributor

The url https://bevyengine.org/examples/tools/gamepad-viewer/ used to take you to the gamepad_viewer example

It is also no longer listed under the tools section: https://bevyengine.org/examples/#tools

You can see it used to work here:
https://web.archive.org/web/20230322224338/https://bevyengine.org/examples/tools/gamepad-viewer/

This was a particularly valuable example for testing gamepads with Wasm, so I doubt it was removed intentionally. Would be great if we could figure out how to get it back up.
@mockersf
Copy link
Member

mockersf commented Aug 6, 2023

It's marked as wasm = false here: https://github.com/bevyengine/bevy/blob/10797d4f159e8686719b32cf95eec69134b11eaa/Cargo.toml#L1310-L1318

If you can confirm it works for you, please open a PR to set it to true

@rparrett rparrett mentioned this issue Aug 9, 2023
Merged
@rparrett
Copy link
Contributor

rparrett commented Aug 9, 2023

It being marked as wasm = false is definitely a mistake. I built it with wasm in mind and it was explicitly added to the website earlier in this PR: #486.

github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this issue Aug 9, 2023
@rparrett
Fix gamepad viewer being marked as a non-wasm example (#9399)
e87d3cc 
# Objective

This example stopped being built for the website after the
example-building was reworked in
(bevyengine/bevy-website#720 + #9168).

This seems to have just been a mistake when defining this particular
example's metadata.

See bevyengine/bevy-website#726

## Solution

Update its metadata to indicate that it works with wasm.
cart pushed a commit to bevyengine/bevy that referenced this issue Aug 10, 2023
@rparrett @cart
Fix gamepad viewer being marked as a non-wasm example (#9399)
e20b78f 
# Objective

This example stopped being built for the website after the
example-building was reworked in
(bevyengine/bevy-website#720 + #9168).

This seems to have just been a mistake when defining this particular
example's metadata.

See bevyengine/bevy-website#726

## Solution

Update its metadata to indicate that it works with wasm.
@rparrett
Copy link
Contributor

It's back!

@paul-hansen
Copy link
Contributor Author

Thanks for grabbing this!

Looks like the url requires a capital letter now:
New: https://bevyengine.org/examples/Tools/gamepad-viewer/
Old: https://bevyengine.org/examples/tools/gamepad-viewer/

Not sure if that's something to be too concerned about or not. Is a slight bummer for any old links to it. I think it just changed because of how we are generating them now, probably affects other examples too.

@rparrett
Copy link
Contributor

Linking a relevant discord conversation: https://discord.com/channels/691052431525675048/695741366520512563/1133883941603000361

I don't think there's an existing GH issue covering that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rparrett @paul-hansen @mockersf