replace withHeaders call with seperate header calls #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I've been using this package since a couple of months and it works great, thanks for your work!
Today I tried to install it on an older project that runs on Laravel 5.1. The only problem I've encountered is that the Laravel middleware uses the new
withHeadersmethod. This method isn't available in 5.1 but the same functionality can easily be replaced by making multiple calls to theheadermethod.This PR fixes this issue. It provides better backwards compatibility without any downsides.
Let me know if I can help or if you have any feedback on this request.
Thanks again for your work,
Barry