Add accesslog params #1132
Merged
Add accesslog params #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i like the idea, however the tests don't pass right now. Seems PATH_INFO doesn't exist during the tests. Can you fix it ? |
|
Oh sorry, I'll fix it. |
Fix KeyError Update access logger tests Update settings.rst docs
bungoume
force-pushed
the
add-accesslog-params
branch
from
972a3e9
to
7dd8a53
Compare
|
Fixed test. Could you review? |
|
LGTM |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
Add accesslog params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add accesslog params like Apache.
If you do not mind, please merge.
ref: http://httpd.apache.org/docs/current/mod/mod_log_config.html